zimgao/gochan
1
0
Fork 0
Code Issues Pull requests Packages Wiki Activity Actions

Merge pull request #20 from LeonardGiglhuber/main

Browse source 
Possible heap overflow: Cancelled orders are not removed
This commit is contained in:
David Braun 2023-07-02 22:59:15 -04:00 • committed by GitHub
commit d559c657c0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 14 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

14
lib/index.js
View file

@ -104,6 +104,20 @@ const Channel = function(length = 0) {
pushes.splice(0, index.push);
shifts.splice(0, index.shift);
// Remove cancelled pushes
for (let i = pushes.length - 1; i >= 0; i--) {
if (pushes[i].cancelled) {
pushes.splice(i, 1);
}
}
// Remove cancelled shifts
for (let i = shifts.length - 1; i >= 0; i--) {
if (shifts[i].cancelled) {
shifts.splice(i, 1);
}
}
};
const readOnly = Object.freeze(