zimgao/gochan
1
0
Fork 0
Code Issues Pull requests Packages Wiki Activity Actions

Functional API: Fix off-by-one bug.

Browse source
This commit is contained in:
David Braun 2017-10-17 20:18:38 -04:00
parent 10f06d08fd
commit 1b1192c0e7
2 changed files with 7 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
lib/index.js
View file

@ -361,10 +361,10 @@ const methods = Object.keys(channel).concat(Object.keys(channel.readOnly()));
methods.forEach(method => {
const bound = function(...args) {
const arity = method === `slice` ? 3 : channel[method].length;
const arity = method === `slice` ? 2 : channel[method].length;
return args.length >= arity
? args[arity - 1][method](...args.slice(0, arity - 1))
return args.length > arity
? args[arity][method](...args.slice(0, arity))
: bound.bind(this, ...args);
};

4
test/index.js
View file

@ -129,6 +129,10 @@ describe(`Channel`, function() {
});
describe(`functional interface`, async function() {
it(`shift`, async function() {
assert.equal(await Channel.shift(Channel.of(0)), 0);
});
describe(`slice`, function() {
it(`full application`, async function() {
assert.deepEqual(