diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 5eb72b8..1b945ae 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -1,7 +1,11 @@ # https://help.github.com/en/articles/workflow-syntax-for-github-actions -on: push name: Build + +on: +- push +- pull_request + jobs: build: name: Build on ${{ matrix.os }} / Node.js v${{ matrix.nodejs }} diff --git a/.github/workflows/verify-on-macos.yml b/.github/workflows/verify-on-macos.yml index f4621b4..274b1e1 100644 --- a/.github/workflows/verify-on-macos.yml +++ b/.github/workflows/verify-on-macos.yml @@ -1,7 +1,11 @@ # https://help.github.com/en/articles/workflow-syntax-for-github-actions -on: push name: macOS + +on: +- push +- pull_request + jobs: ssh: name: Connect to github.com diff --git a/.github/workflows/verify-on-ubuntu.yml b/.github/workflows/verify-on-ubuntu.yml index 6577545..2400e1e 100644 --- a/.github/workflows/verify-on-ubuntu.yml +++ b/.github/workflows/verify-on-ubuntu.yml @@ -1,7 +1,11 @@ # https://help.github.com/en/articles/workflow-syntax-for-github-actions -on: push name: Ubuntu + +on: +- push +- pull_request + jobs: ssh: name: Connect to github.com diff --git a/.github/workflows/verify-on-ubuntu1604.yml b/.github/workflows/verify-on-ubuntu1604.yml index a9d0fb6..01efc32 100644 --- a/.github/workflows/verify-on-ubuntu1604.yml +++ b/.github/workflows/verify-on-ubuntu1604.yml @@ -1,7 +1,11 @@ # https://help.github.com/en/articles/workflow-syntax-for-github-actions -on: push name: Ubuntu 16.04 + +on: +- push +- pull_request + jobs: ssh: name: Connect to github.com diff --git a/.github/workflows/verify-on-windows.yml b/.github/workflows/verify-on-windows.yml index c65b2b1..bfd62d5 100644 --- a/.github/workflows/verify-on-windows.yml +++ b/.github/workflows/verify-on-windows.yml @@ -1,7 +1,11 @@ # https://help.github.com/en/articles/workflow-syntax-for-github-actions -on: push name: Windows + +on: +- push +- pull_request + jobs: ssh: name: Connect to github.com diff --git a/README.md b/README.md index 54dc1db..af5a78e 100644 --- a/README.md +++ b/README.md @@ -19,7 +19,7 @@ Useful for SCP, SFTP, and `rsync` over SSH in deployment script. Add your SSH key to your product secrets by clicking `Settings` - `Secrets` - `Add a new secret` beforehand. -**NOTE:** OPENSSH format (key begins with `-----BEGIN OPENSSH PRIVATE KEY-----`) may not work due to OpenSSH version on VM. Please use PEM format (begins with `-----BEGIN RSA PRIVATE KEY-----`) instead. +**NOTE:** OPENSSH format (key begins with `-----BEGIN OPENSSH PRIVATE KEY-----`) may not work due to OpenSSH version on VM. Please use PEM format (begins with `-----BEGIN RSA PRIVATE KEY-----`) instead. In order to convert your key inline to PEM format simply use `ssh-keygen -p -m PEM -f ~/.ssh/id_rsa`. ```yaml runs-on: ubuntu-latest @@ -78,11 +78,11 @@ steps: ### SSH failed even though key has been installed. -Check belows: +Check below: * `Load key "/HOME/.ssh/id_rsa": invalid format`: * OPENSSH format (key begins with `-----BEGIN OPENSSH PRIVATE KEY-----`) may not work. - * Use PEM format (begins with `-----BEGIN RSA PRIVATE KEY-----`). + * Use PEM format (begins with `-----BEGIN RSA PRIVATE KEY-----`). Convert it from OPENSSH format using `ssh-keygen -p -m PEM -f ~/.ssh/id_rsa` * `Host key verification failed.`: * Set `known_hosts` option correctly (use `ssh-keyscan` command).